If the ssh agent hasn't been given, then check for qrsh and friends #1318
Conversation
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
@rhc54 I note that this is quite a bit more than the cherry-picked open-mpi/ompi@1c44543. Was that intentional? |
|
Doing a little log spelunking, it looks like this also includes open-mpi/ompi@5717b75. |
| * environment variables. If so, setup the path and argv[0]. | ||
| * Note that we allow the user to specify the launch agent | ||
| * even if they are in a Grid Engine environment */ | ||
| if (0 == strcmp(mca_plm_rsh_component.agent, "ssh : rsh")) { |
There was a problem hiding this comment.
Minor nit: open-mpi/ompi#1972 might be a more robust way to check to see if we're not using the default value...?
|
Other than the two minor nits (which can be fixed after this PR), as long as open-mpi/ompi@5717b75 was intended to be in this PR, 👍 |
(cherry picked from commit open-mpi/ompi@1c44543) Restore the rsh template creation code (cherry picked from commit open-mpi/ompi@5717b75) Further cleanup getpwuid usage - try it first (unless completely disabled), and then silently failover to try other methods. (cherry picked from commit open-mpi/ompi@9f43db7)
|
I didn't worry about the history of the changes - I just fixed the problem 😄 This should now be complete. We can add the better way of detecting default later. |
|
You really like squashing your commits, don't you? 😄 It took a minute to figure out what was new in your new commit (i.e., the getpwent stuff). Looks good. I agree that the (potentially) more robust check can be added later. |
|
@hppritcha Once CI finishes, this is good to go. |
|
Test PASSed. |
|
False Travis failure (we killed the build because it was taking hours and it hadn't even start yet). |
5 participants
(cherry picked from commit open-mpi/ompi@1c44543)